-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Add FLAC in ISO-BMFF with MSE Sample #538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FLAC in ISO-BMFF with MSE Sample #538
Conversation
09a52bd to
ba47537
Compare
|
While playing with FLAC in MP4, I've also tried this sample with Firefox and it fails ;( I've created a simple page at https://beaufortfrancois.github.io/sandbox/media/flac-in-mp4-for-mse.html so that we can reproduce the issue in Firefox Stable and Developer Edition. @jyavenard The |
|
@beaufortfrancois |
|
And do we need a 192kHz/24bits file ? |
|
Is that a Firefox thing or should Chrome behave this way as well? /me reading https://people.xiph.org/~xiphmont/demo/neil-young.html |
|
We require that the SampleDescriptionBox content be valid (AudioSampleEntry in this case) I understand that here the information is redundant with the fLaC box also present, but as our demuxer is very generic, it relies on the "universal" boxes to be valid. We could always relax the rules in this case, but may as well create a proper file to start with, especially if it's supposed to be used as reference. |
|
QQ: Did you use a web app to read flac header info? |
|
In this case I just looked on why it errored and trace back where that failed. The Bento4 suite has tools that can display the content of an mp4 (mp4 in particular) |
|
The original file was created with ffmpeg. If I don't specify For future reference, the old file is still accessible at https://storage.googleapis.com/media-session/flac-192kHz_frag.mp4 Update: I've filed a ffmpeg ticket at https://trac.ffmpeg.org/ticket/6609#ticket thanks to @jyavenard's help. |
@jyavenard Is that an improvement for |
|
Note, 192kHz/24bits (while I agree with #538 (comment)), I include that as a test file in Chromium's implementation of FLAC-in-MSE because the FLAC-in-ISOBMFF spec gives instruction on how to mark signal rates that exceed AudioSampleEntry's max 65535.0Hz to ensure that we can demux the correct sample rate. Of course, the platform's audio path post-decode likely downsamples (or otherwise probably has ultrasonic intermodulation distortion) at such high samplerates. |
|
@wolenetz : that MP4 file isn't per ISO/IEC 14496-12 spec, nor per FLAC-in-ISOBMFF
as it is, the rate is set as 0. |
|
playing that file only encourage bad future file. |
|
@beaufortfrancois Note this feature is still pending launch approvals for M62 - follow along on the internal launch https://crbug.com/750868 |
|
@jyavenard (#538 (comment)) That makes sense. @beaufortfrancois Please don't land this until all of: |
|
The original file comes from https://chromium.googlesource.com/chromium/src/+/master/media/test/data/bear-flac.mp4 and I believe @jyavenard used his patch to generate the new file that works well in Chrome & Firefox. Update from 17/09/01: @jyavenard said it's good from his side. FYI, until I merge this, we can play with this sample at https://beaufortfrancois.github.io/samples/media/flac-in-mp4-for-mse.html |

Hello @wolenetz,
Do you mind reviewing this sample?